Subject: Re: [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet driver

From: Ben Hutchings <[email-masked]>
Date: Thu, 17 Jul 2008 21:23:01 +0100

Mariusz Kozlowski wrote:
> Hello,
> 
> > +#define SPEED_0		   0xffff
> > +#define SPEED_10           10
> > +#define SPEED_100          100
> > +#define SPEED_100          100
> 
> Small thing - double define for SPEED_100.
> 
> > +#define SPEED_1000         1000

In fact these are all duplicates of macros defined in <linux/ethtool.h>
(except SPEED_0, whatever that means).

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.