Subject: Re: [PATCH] pkt_sched: Fix dev_graft_qdisc() locking

From: Jarek Poplawski <[email-masked]>
Date: Tue, 26 Aug 2008 13:05:36 +0000

On Tue, Aug 26, 2008 at 10:48:13PM +1000, Herbert Xu wrote:
> Jarek Poplawski <[email-masked]> wrote:
> > pkt_sched: Fix dev_graft_qdisc() locking
> > 
> > During dev_graft_qdisc() dev is deactivated, so qdisc_root_lock()
> > returns wrong lock of noop_qdisc instead of qdisc_sleeping.
> > 
> > 
> > Signed-off-by: Jarek Poplawski <[email-masked]>
> 
> Looks good to me!
> 
> Acked-by: Herbert Xu <[email-masked]>
> 

BTW, I should've probably mention this lock doesn't probably
matter here much, after current precise deactivation.

Thanks,
Jarek P.