From: Stephen Hemminger <shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public•gmane.org>
To: Alexey Dobriyan <adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
containers-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public•gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org
Subject: Re: [PATCH 2/2] netns bridge: cleanup bridges during netns stop
Date: Sat, 6 Sep 2008 18:38:21 -0700 [thread overview]
Message-ID: <20080906183821.1da26204@extreme> (raw)
In-Reply-To: <20080906064408.GB7810-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
On Sat, 6 Sep 2008 10:44:08 +0400
Alexey Dobriyan <adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org> wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
> ---
>
> net/bridge/br.c | 22 ++++++++++++++++------
> net/bridge/br_if.c | 4 ++--
> net/bridge/br_private.h | 2 +-
> 3 files changed, 19 insertions(+), 9 deletions(-)
>
> --- a/net/bridge/br.c
> +++ b/net/bridge/br.c
> @@ -28,6 +28,10 @@ static const struct stp_proto br_stp_proto = {
> .rcv = br_stp_rcv,
> };
>
> +static struct pernet_operations br_net_ops = {
> + .exit = br_net_exit,
> +};
> +
Acked-by: Stephen Hemminger <shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public•gmane.org>
overall, this is fine, but you might want to think about making
pernet_operations const if possible in future.
next prev parent reply other threads:[~2008-09-07 1:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-06 6:44 [PATCH 2/2] netns bridge: cleanup bridges during netns stop Alexey Dobriyan
[not found] ` <20080906064408.GB7810-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
2008-09-07 1:38 ` Stephen Hemminger [this message]
2008-09-07 14:08 ` Alexey Dobriyan
2008-09-08 23:20 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2008-08-21 22:18 adobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080906183821.1da26204@extreme \
--to=shemminger-ztmgi6mnkb3qt0dzr+alfa@public$(echo .)gmane.org \
--cc=adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=containers-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox