public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge•net.au>
To: lvs-devel@vger•kernel.org, netdev@vger•kernel.org
Cc: "Siim Põder" <siim@p6drad-teel•net>,
	"Julian Anastasov" <ja@ssi•bg>,
	"Malcolm Turnbull" <malcolm@loadbalancer•org>,
	"Julius Volz" <juliusv@google•com>,
	"Vince Busam" <vbusam@google•com>,
	"Herbert Xu" <herbert@gondor•apana.org.au>
Subject: Re: [rfc 0/3] IPVS: checksum updates
Date: Tue, 9 Sep 2008 09:40:29 +1000	[thread overview]
Message-ID: <20080908234028.GF13048@verge.net.au> (raw)
In-Reply-To: <20080908020420.313463898@vergenet.net>

On Mon, Sep 08, 2008 at 12:04:20PM +1000, Simon Horman wrote:
> Hi,
> 
> The impetus for this series of patches is Julian Anastasov noting
> that "load balance IPv4 connections from a local process" checks
> for 0 TCP checksums. Herbert Xu confirmed that this is not legal,
> even on loopback traffic, but that rather partial checksums are
> possible.
> 
> The first patch in this series is a proposed solution to handle
> partial checksums for both TCP and UDP.
> 
> The other two patches clean things up a bit.
> 
> I have not tested this code beyond compilation yet.

After extensive testing by Julius Volz and limited testing by myself, I
have applied the first patch, which does indeed allow packets with
PARTIAL_CHECKSUM to work, to lvs-next-2.6. I have dropped the second two
patches which produce bogus checksums.

I will revisit the second to patches at some point and try and produce
versions that work.


  parent reply	other threads:[~2008-09-08 23:40 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-08  2:04 [rfc 0/3] IPVS: checksum updates Simon Horman
2008-09-08  2:04 ` [rfc 1/3] ipvs: handle PARTIAL_CHECKSUM Simon Horman
2008-09-08  7:24   ` Herbert Xu
2008-09-08  9:05     ` Simon Horman
2008-09-08  9:54       ` Herbert Xu
2008-09-08  2:04 ` [rfc 2/3] ipvs: Use inet_proto_csum_replace*() Simon Horman
2008-09-08  2:04 ` [rfc 3/3] ipvs: Consolidate checksuming code Simon Horman
2008-09-08 10:03 ` [rfc 0/3] IPVS: checksum updates Julius Volz
2008-09-08 10:41   ` Simon Horman
2008-09-08 11:42     ` Julius Volz
2008-09-08 11:57       ` Simon Horman
2008-09-08 12:04         ` Simon Horman
2008-09-08 12:14           ` Julius Volz
2008-09-08 12:34             ` Simon Horman
2008-09-08 13:12               ` Julius Volz
2008-09-08 13:20                 ` Simon Horman
2008-09-08 13:42                   ` Julius Volz
2008-09-08 15:32                     ` Julius Volz
2008-09-08 23:22                       ` Simon Horman
2008-09-08 23:40 ` Simon Horman [this message]
2008-09-09  9:30   ` Julius Volz
2008-09-09 11:31     ` Simon Horman
2008-09-10 17:30       ` Julius Volz
2008-09-10 23:29         ` Simon Horman
2008-09-11 13:07           ` Wensong Zhang
2008-09-11 13:45             ` Simon Horman
2008-09-11 13:55               ` Julius Volz
2008-09-11 14:43                 ` Wensong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080908234028.GF13048@verge.net.au \
    --to=horms@verge$(echo .)net.au \
    --cc=herbert@gondor$(echo .)apana.org.au \
    --cc=ja@ssi$(echo .)bg \
    --cc=juliusv@google$(echo .)com \
    --cc=lvs-devel@vger$(echo .)kernel.org \
    --cc=malcolm@loadbalancer$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=siim@p6drad-teel$(echo .)net \
    --cc=vbusam@google$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox