Subject: Re: [PATCH 02/14] Phonet: add CONFIG_PHONET

From: Arnaldo Carvalho de Melo <[email-masked]>
Date: Tue, 16 Sep 2008 13:06:12 -0300

Em Tue, Sep 16, 2008 at 06:08:02PM +0300, Rémi Denis-Courmont escreveu:
> Signed-off-by: Remi Denis-Courmont <[email-masked]>
> ---
>  net/phonet/Kconfig  |   11 +++++++++++
>  net/phonet/Makefile |    3 +++
>  2 files changed, 14 insertions(+), 0 deletions(-)
>  create mode 100644 net/phonet/Kconfig
>  create mode 100644 net/phonet/Makefile
> 
> diff --git a/net/phonet/Kconfig b/net/phonet/Kconfig
> new file mode 100644
> index 0000000..02f8921
> --- /dev/null
> +++ b/net/phonet/Kconfig
> @@ -0,0 +1,11 @@
> +#
> +# Phonet protocol
> +#
> +
> +config PHONET
> +	tristate "Phonet protocols family"
> +	help
> +	  Phonet is a communication protocol used by Nokia modems.
> +
> +	  To compile this driver as a module, choose M here: the module
> +	  will be called phonet. If unsure, say N.

I think you could expand this a bit, no? Telling in which platforms this
would be used, i.e. nokia devices such as the N8x0 and not on a desktop
with a Nokia modem attached, etc.

Recently there were complaints about Kconfig help entries being too
terse, lets not add more of these.

- Arnaldo