From: akpm@linux-foundation•org
To: davem@davemloft•net
Cc: netdev@vger•kernel.org, akpm@linux-foundation•org,
kaih.luo@gmail•com, jengelh@computergmbh•de, kaber@trash•net
Subject: [patch 2/8] netfilter: xt_time gives a wrong monthday in a leap year
Date: Mon, 22 Sep 2008 14:50:36 -0700 [thread overview]
Message-ID: <200809222150.m8MLoaXW031860@imap1.linux-foundation.org> (raw)
From: Kaihui Luo <kaih.luo@gmail•com>
The function localtime_3 in xt_time.c gives a wrong monthday in a leap
year after 28th 2. calculating monthday should use the array
days_since_leapyear[] not days_since_year[] in a leap year.
Signed-off-by: Kaihui Luo <kaih.luo@gmail•com>
Acked-by: Jan Engelhardt <jengelh@computergmbh•de>
Cc: Patrick McHardy <kaber@trash•net>
Signed-off-by: Andrew Morton <akpm@linux-foundation•org>
---
net/netfilter/xt_time.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff -puN net/netfilter/xt_time.c~netfilter-xt_time-gives-a-wrong-monthday-in-a-leap-year net/netfilter/xt_time.c
--- a/net/netfilter/xt_time.c~netfilter-xt_time-gives-a-wrong-monthday-in-a-leap-year
+++ a/net/netfilter/xt_time.c
@@ -136,17 +136,19 @@ static void localtime_3(struct xtm *r, t
* from w repeatedly while counting.)
*/
if (is_leap(year)) {
+ /* use days_since_leapyear[] in a leap year */
for (i = ARRAY_SIZE(days_since_leapyear) - 1;
- i > 0 && days_since_year[i] > w; --i)
+ i > 0 && days_since_leapyear[i] > w; --i)
/* just loop */;
+ r->monthday = w - days_since_leapyear[i] + 1;
} else {
for (i = ARRAY_SIZE(days_since_year) - 1;
i > 0 && days_since_year[i] > w; --i)
/* just loop */;
+ r->monthday = w - days_since_year[i] + 1;
}
r->month = i + 1;
- r->monthday = w - days_since_year[i] + 1;
return;
}
_
next reply other threads:[~2008-09-22 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 21:50 akpm [this message]
2008-09-23 2:03 ` [patch 2/8] netfilter: xt_time gives a wrong monthday in a leap year David Miller
2008-09-24 9:29 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809222150.m8MLoaXW031860@imap1.linux-foundation.org \
--to=akpm@linux-foundation$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=jengelh@computergmbh$(echo .)de \
--cc=kaber@trash$(echo .)net \
--cc=kaih.luo@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox