Subject: Re: [patch 4/4] mISDN: misc timerdev fixes

From: Andrew Morton <[email-masked]>
Date: Tue, 23 Sep 2008 04:30:05 -0700

On Tue, 23 Sep 2008 06:40:26 -0400 Christoph Hellwig <[email-masked]> wrote:

> On Mon, Sep 22, 2008 at 02:51:03PM -0700, [email-masked] wrote:
> > From: Andi Kleen <[email-masked]>
> > 
> > - Remove noop VFS stubs. The VFS does that on a NULL pointer anyways.
> 
> > -static loff_t
> > -mISDN_llseek(struct file *filep, loff_t offset, int orig)
> > -{
> > -	return -ESPIPE;
> > -}
> 
> >  static struct file_operations mISDN_fops = {
> > -	.llseek		= mISDN_llseek,
> 
> This is wrong.  no llseek means we use default_llseek, which is
> different from returning -ESPIPE.

so.. this?

--- a/drivers/isdn/mISDN/timerdev.c~misdn-misc-timerdev-fixes-fix
+++ a/drivers/isdn/mISDN/timerdev.c
@@ -61,7 +61,7 @@ mISDN_open(struct inode *ino, struct fil
 	init_waitqueue_head(&dev->wait);
 	filep->private_data = dev;
 	__module_get(THIS_MODULE);
-	return 0;
+	return nonseekable_open(ino, filep);
 }
 
 static int
_