From: Simon Horman <horms@verge•net.au>
To: Brian Haley <brian.haley@hp•com>
Cc: Jay Vosburgh <fubar@us•ibm.com>,
David Miller <davem@davemloft•net>,
Vladislav Yasevich <vladislav.yasevich@hp•com>,
Alex Sidorenko <alexandre.sidorenko@hp•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH] bonding: send IPv6 neighbor advertisement on failover
Date: Wed, 8 Oct 2008 18:26:34 +1100 [thread overview]
Message-ID: <20081008072632.GL22396@verge.net.au> (raw)
In-Reply-To: <48EC091D.7080207@hp.com>
On Tue, Oct 07, 2008 at 09:13:01PM -0400, Brian Haley wrote:
> This patch adds better IPv6 failover support for bonding devices,
> especially when in active-backup mode and there are only IPv6 addresses
> configured, as reported by Alex Sidorenko.
>
> - Creates a new file, net/drivers/bonding/bond_ipv6.c, for the
> IPv6-specific routines. Both regular bonds and VLANs over bonds
> are supported.
>
> - Adds a new tunable, num_unsol_na, to limit the number of unsolicited
> IPv6 Neighbor Advertisements that are sent on a failover event.
> Default is 1.
>
> - Creates two new IPv6 neighbor discovery functions:
>
> ndisc_build_skb()
> ndisc_send_skb()
>
> These were required to support VLANs since we have to be able to
> add the VLAN id to the skb since ndisc_send_na() and friends
> shouldn't be asked to do this. These two routines are basically
> __ndisc_send() split into two pieces, in a slightly different order.
>
> - Updates Documentation/networking/bonding.txt and bumps the rev of bond
> support to 3.4.0.
>
> On failover, this new code will generate one packet:
>
> - An unsolicited IPv6 Neighbor Advertisement, which helps the switch
> learn that the address has moved to the new slave.
>
> Testing has shown that sending just the NA results in pretty good
> behavior when in active-back mode, I saw no lost ping packets for
> example.
>
> -Brian
>
> Signed-off-by: Brian Haley <brian.haley@hp•com>
The Kconfig / build portions of this look fine to me.
--
Simon Horman
VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en
next prev parent reply other threads:[~2008-10-08 7:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 1:13 [PATCH] bonding: send IPv6 neighbor advertisement on failover Brian Haley
2008-10-08 7:26 ` Simon Horman [this message]
2008-10-08 17:40 ` David Stevens
2008-10-08 18:08 ` Vlad Yasevich
2008-10-08 18:19 ` David Stevens
2008-10-08 19:01 ` Brian Haley
2008-10-08 22:22 ` Sridhar Samudrala
2008-10-09 2:08 ` Brian Haley
2008-10-08 19:12 ` Vlad Yasevich
2008-10-08 19:41 ` David Stevens
2008-10-08 19:53 ` Vlad Yasevich
2008-10-08 18:15 ` Vlad Yasevich
2008-10-08 18:34 ` Jay Vosburgh
2008-10-08 19:05 ` Brian Haley
2008-10-08 19:07 ` Vlad Yasevich
2008-10-08 19:36 ` Jay Vosburgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081008072632.GL22396@verge.net.au \
--to=horms@verge$(echo .)net.au \
--cc=alexandre.sidorenko@hp$(echo .)com \
--cc=brian.haley@hp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fubar@us$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vladislav.yasevich@hp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox