Subject: Re: [Bugme-new] [Bug 11754] New: tlan network driver does not work

From: Stephen Hemminger <[email-masked]>
Date: Fri, 24 Oct 2008 17:18:35 -0700

On Sat, 25 Oct 2008 01:00:33 +0100
Robert Fitzsimons <[email-masked]> wrote:

> I've double checked my patch and still think it's correct.  Lets quickly
> review it:
> 
> @@ -360,8 +360,8 @@ TLan_GetSKB( const struct tlan_list_tag *tag)
>  {
>  	unsigned long addr;
>  
> -	addr = tag->buffer[8].address;
> -	addr |= (tag->buffer[9].address << 16) << 16;
> +	addr = tag->buffer[9].address;
> +	addr |= (tag->buffer[8].address << 16) << 16;

There is upper_32_bits(x) and lower_32_bits(x) for this (see kernel.h)