From: Paul Moore <paul.moore@hp•com>
To: "Manish Katiyar" <mkatiyar@gmail•com>
Cc: netdev@vger•kernel.org, kernel-janitors@vger•kernel.org
Subject: Re: [PATCH] : Fix compilation warnings in net/netlabel/netlabel_addrlist.c
Date: Thu, 30 Oct 2008 08:12:39 -0400 [thread overview]
Message-ID: <200810300812.39810.paul.moore@hp.com> (raw)
In-Reply-To: <ea11fea30810291910v1f99b62arcc63285fefe8bf72@mail.gmail.com>
On Wednesday 29 October 2008 10:10:36 pm Manish Katiyar wrote:
> On Thu, Oct 30, 2008 at 1:13 AM, Paul Moore <paul.moore@hp•com> wrote:
> > On Wednesday 29 October 2008 2:27:44 pm you wrote:
> >> Hi Paul,
> >>
> >> Does this look better ?? Appreciate your help. Patch compile
> >> tested.
> >>
> >> Enable netlabel auditing functions only when CONFIG_AUDIT is set
> >>
> >> Signed-off-by: Manish Katiyar <mkatiyar@gmail•com>
> >
> > Much better, just some style nits noted below that need to be
> > addressed ...
>
> Hi Paul,
>
> Updated patch below as per your comments.
>
> Enable netlabel auditing functions only when CONFIG_AUDIT is set
>
> Signed-off-by: Manish Katiyar <mkatiyar@gmail•com>
Thanks for sticking with this, I appreciate it. There is still one
small style nit (see below) but it is really my fault for not being
more specific. Unless you object I'll go ahead and fix it up when I
apply the patch.
I'll send a git pull request out to netdev later today, including your
patch, as there are two other labeled networking patches that need to
make the next 2.6.28-rcX release.
> ---
> net/netlabel/netlabel_addrlist.c | 2 ++
> net/netlabel/netlabel_addrlist.h | 22 ++++++++++++++++++++++
> 2 files changed, 24 insertions(+), 0 deletions(-)
>
> diff --git a/net/netlabel/netlabel_addrlist.c
> b/net/netlabel/netlabel_addrlist.c index b0925a3..3fe73c2 100644
> --- a/net/netlabel/netlabel_addrlist.c
> +++ b/net/netlabel/netlabel_addrlist.c
> @@ -327,6 +327,7 @@ struct netlbl_af6list
> *netlbl_af6list_remove(const struct in6_addr *addr,
> * Write the IPv4 address and address mask, if necessary, to
> @audit_buf. *
> */
> +#ifdef CONFIG_AUDIT
> void netlbl_af4list_audit_addr(struct audit_buffer *audit_buf,
> int src, const char *dev,
> __be32 addr, __be32 mask)
When I said to move the #ifdef below the comment, I meant below
the "Audit Helper Functions" comment but before the function's kdoc
comment header.
--
paul moore
linux @ hp
next prev parent reply other threads:[~2008-10-30 12:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 8:06 [PATCH] : Fix compilation warnings in net/netlabel/netlabel_addrlist.c Manish Katiyar
2008-10-29 13:49 ` Paul Moore
[not found] ` <ea11fea30810290818p2ae6c11eo5e38baf631867fb1@mail.gmail.com>
[not found] ` <200810291135.25056.paul.moore@hp.com>
2008-10-29 18:27 ` Manish Katiyar
[not found] ` <200810291543.49225.paul.moore@hp.com>
2008-10-30 2:10 ` Manish Katiyar
2008-10-30 12:12 ` Paul Moore [this message]
2008-10-30 13:33 ` Manish Katiyar
2008-10-30 13:39 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810300812.39810.paul.moore@hp.com \
--to=paul.moore@hp$(echo .)com \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=mkatiyar@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox