Subject: Re: ssb: Fix DMA-API compilation for non-PCI systems

From: Michael Buesch <[email-masked]>
Date: Mon, 10 Nov 2008 23:07:37 +0100

On Monday 10 November 2008 22:52:31 David Miller wrote:
> 
> I applied this since it's a build buster and we should
> get it fixed quickly.
> 
> But as I look at this, the thing to really do here is get
> rid of these stupid switch statements.  None of it is needed.
> 
> The layer that sets up the SSB devices should simply save the
> generic device pointer for the DMA entity into some new
> ->dma_dev struct member.
>
> Then you just use generic dma_*() interfaces unilaterally.  For PCI
> devices it will "just work".

We tried that. It doesn't work. It breaks on several architectures
that do special things in the pci_dma... functions.
See the git history and mailinglists, please.

-- 
Greetings Michael.