From: Michael Buesch <mb@bu3sch•de>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org
Subject: Re: ssb: Fix DMA-API compilation for non-PCI systems
Date: Tue, 11 Nov 2008 00:32:00 +0100 [thread overview]
Message-ID: <200811110032.00814.mb@bu3sch.de> (raw)
In-Reply-To: <20081110.145343.171487164.davem@davemloft.net>
On Monday 10 November 2008 23:53:43 David Miller wrote:
> Then those architectures need to fix their implementations,
> simply. They aren't implementing the generic DMA interfaces
> properly. Other subsystems do make use of the generic DMA
> interfaces in this way.
>
> Even something as simple as checking for &pci_bus_type in the
> dma_*() routines (like powerpc did for quite some time) is
> enough to fix the problem.
Yeah, sure. The architectures are broken.
But the bugreports hit _my_ code. I got pretty tired of forwarding stuff
to the arch maintainers, so I implemented something that does work in
every situation. The bugreports stopped immediately (Except this tiny build
failure that does only hit under rare circumstances).
DMA is pretty much a mess, if you look at how ever arch does implement the API
in a slightly different way.
If somebody wants to fix this, I'm certainly OK with it. But for now we will
have to live with SSB implementing a wrapper around the ssb-host-device DMA APIs.
--
Greetings Michael.
next prev parent reply other threads:[~2008-11-10 23:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 21:52 ssb: Fix DMA-API compilation for non-PCI systems David Miller
2008-11-10 22:07 ` Michael Buesch
2008-11-10 22:53 ` David Miller
2008-11-10 23:32 ` Michael Buesch [this message]
2008-11-11 8:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811110032.00814.mb@bu3sch.de \
--to=mb@bu3sch$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox