From: Greg KH <greg@kroah•com>
To: Eric Dumazet <dada1@cosmosbay•com>
Cc: stable@kernel•org, "David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org
Subject: Re: [stable] [BUG] net: fix /proc/net/snmp as memory corruptor
Date: Sat, 15 Nov 2008 10:43:09 -0800 [thread overview]
Message-ID: <20081115184309.GA24983@kroah.com> (raw)
In-Reply-To: <491E8A47.1090007@cosmosbay.com>
On Sat, Nov 15, 2008 at 09:37:27AM +0100, Eric Dumazet wrote:
> Greg KH a écrit :
>> On Sat, Nov 15, 2008 at 06:25:33AM +0100, Eric Dumazet wrote:
>>> Greg KH a écrit :
>>>> On Fri, Nov 14, 2008 at 06:08:48AM +0100, Eric Dumazet wrote:
>>>>> Hello Greg
>>>>>
>>>>> A patch was submited about /proc/net/snmp being a memory corruptor and
>>>>> not SMP safe
>>>>>
>>>>> (commit b971e7ac834e9f4bda96d5a96ae9abccd01c1dd8)
>>>>>
>>>>> These bugs are present on 2.6.26 & 2.6.27.
>>>> I looking at this, it doesn't seem to apply at all to the .27 tree. If
>>>> David doesn't object, care to backport it there and send it to
>>>> stable@kernel•org?
>>> Strange... I just tried to apply patch on top of a fresh linux-2.6.27.6
>>> tree and got no error
>>>
>>> # patch -p1 < /tmp/icmp_snmp.patch
>>> patching file net/ipv4/proc.c
>>> #
>> I've attached the patch I tried to apply below. It fails with:
>> $ patch -p1 --dry-run <
>> ../net-fix-proc-net-snmp-as-memory-corruptor.patch patching file
>> net/ipv4/proc.c
>> Hunk #1 FAILED at 237.
>> 1 out of 1 hunk FAILED -- saving rejects to file net/ipv4/proc.c.rej
>> Any thoughts?
>> thanks,
>> greg k-h
>
> Yes, you lost all the '\' character in "\n" sequences... Also one missing
> ":" at the end of one line
>
> I dont know how you did it :)
Oh crap, that's my fault. I hate bash at times, I'm using a script to
copy changesets and format them in the way that works for the stable
tree. I need to switch it to perl so these things don't happen :(
In looking closer, I also messed up on some other patches in this -rc1,
I need to redo the whole thing. Ugh.
Thanks for pointing this out, I'll fix it up.
greg k-h
next prev parent reply other threads:[~2008-11-15 18:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <491D07E0.9010903@cosmosbay.com>
2008-11-15 5:10 ` [stable] [BUG] net: fix /proc/net/snmp as memory corruptor Greg KH
2008-11-15 5:25 ` Eric Dumazet
2008-11-15 6:02 ` Greg KH
2008-11-15 8:37 ` Eric Dumazet
2008-11-15 18:43 ` Greg KH [this message]
2008-11-17 4:51 ` Greg KH
2008-11-17 6:04 ` Eric Dumazet
2008-11-15 6:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081115184309.GA24983@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=dada1@cosmosbay$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox