Subject: Re: [PATCH netdev-2.6] jme: JMicron Gigabit Ethernet Driver

From: Stephen Hemminger <[email-masked]>
Date: Thu, 20 Nov 2008 22:45:42 -0800

On Thu, 20 Nov 2008 21:36:27 -0800 (PST)
David Miller <[email-masked]> wrote:

> From: Stephen Hemminger <[email-masked]>
> Date: Thu, 20 Nov 2008 21:20:45 -0800
> 
> > 6. Not using pci dma allocation which is more standard convention
> 
> Using the generic DMA interfaces is actually preferred.  There is
> no effective difference other than using a more generic interface.

Ok, but this???

#define NET_STAT(priv) (priv->dev->stats)
#define NETDEV_GET_STATS(netdev, fun_ptr)
#define DECLARE_NET_DEVICE_STATS

#define DECLARE_NAPI_STRUCT struct napi_struct napi;
#define NETIF_NAPI_SET(dev, napis, pollfn, q) \
	netif_napi_add(dev, napis, pollfn, q);
#define JME_NAPI_HOLDER(holder) struct napi_struct *holder
#define JME_NAPI_WEIGHT(w) int w
#define JME_NAPI_WEIGHT_VAL(w) w
#define JME_NAPI_WEIGHT_SET(w, r)
#define JME_RX_COMPLETE(dev, napis) netif_rx_complete(dev, napis)
#define JME_NAPI_ENABLE(priv) napi_enable(&priv->napi);
#define JME_NAPI_DISABLE(priv) \
	if (!napi_disable_pending(&priv->napi)) \
		napi_disable(&priv->napi);
#define JME_RX_SCHEDULE_PREP(priv) \
	netif_rx_schedule_prep(priv->dev, &priv->napi)
#define JME_RX_SCHEDULE(priv) \
	__netif_rx_schedule(priv->dev, &priv->napi);