Subject: Re: [NET-NEXT PATCH] ixgbe: Implement PCIe AER support

From: Stephen Hemminger <[email-masked]>
Date: Mon, 1 Dec 2008 17:47:54 -0800

On Mon, 01 Dec 2008 16:41:15 -0800
Jeff Kirsher <[email-masked]> wrote:

> From: PJ Waskiewicz <[email-masked]>
> 
> This patch implements the PCIe Advanced Error Reporting callbacks in
> ixgbe.  The 82598 hardware supports AER, so we enable it.
> 
> Signed-off-by: Peter P Waskiewicz Jr <[email-masked]>
> Signed-off-by: Jeff Kirsher <[email-masked]>
> ---

Once again: pcie-aer is not checking for mmconfig working!
If you turn it on, you may get screaming errors.

pci_enable_pcie_error_reporting should be checking for pci_read/pci_write
config errors and does not.

Your driver should be checking for pci_enable_pcie_error_reporting failing.