Subject: Re: [PATCH 6/8] tcp: Add GRO support

From: Evgeniy Polyakov <[email-masked]>
Date: Sat, 13 Dec 2008 05:40:46 +0300

On Sat, Dec 13, 2008 at 08:46:27AM +1100, Herbert Xu ([email-masked]) wrote:
> > > +	flush |= memcmp(th + 1, th2 + 1, thlen - sizeof(*th));
> > > +
> > > +	total = p->len;
> > > +	mss = total;
> > > +	if (skb_shinfo(p)->frag_list)
> > > +		mss = skb_shinfo(p)->frag_list->len;
> > > +
> > > +	flush |= skb->len > mss || skb->len <= 0;
> > > +	flush |= ntohl(th2->seq) + total != ntohl(th->seq);
> > > +
> > 
> > No timestamp check?
> 
> The memcmp does that for us.

So it will fail if timestamp changed? Or if some new option added?

-- 
	Evgeniy Polyakov