From: David Miller <davem@davemloft•net>
To: shemminger@vyatta•com
Cc: jeffrey.t.kirsher@intel•com, donald.c.skidmore@intel•com,
netdev@vger•kernel.org
Subject: Re: ixgbe select_queue broken in 2.6.28
Date: Fri, 02 Jan 2009 00:19:33 -0800 (PST) [thread overview]
Message-ID: <20090102.001933.70654029.davem@davemloft.net> (raw)
In-Reply-To: <20090101225456.68f4fe9d@extreme>
From: Stephen Hemminger <shemminger@vyatta•com>
Date: Thu, 1 Jan 2009 22:54:56 -0800
> The ixgbe driver in 2.6.28 modifies select_queue. This is bad
> in a couple of ways:
> 1) select_queue is now in net_device_ops so the driver won't build
> unless CONFIG_COMPAT_NET_DEV_OPS is defined
> 2) it is changing data that is shared and supposed to be immutable.
>
> Looks like a some of the DCB stuff forgot to look at net_device_ops
Drivers shouldn't be overriding the ->select_queue() method unless
there is a very specific reason to do so. Ethernet drivers will not
have such a reason.
This is a very bad trend and I think I'm going to need to simply
remove the ->select_queue() method to stop the bleeding.
If people keep overriding this method in their drivers, then when we
move to more sophisticated methods of computing the hash we will have
to hit all of these override spots which makes the generic queue
selection function pointless.
next prev parent reply other threads:[~2009-01-02 8:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-02 6:54 ixgbe select_queue broken in 2.6.28 Stephen Hemminger
2009-01-02 8:19 ` David Miller [this message]
2009-01-05 3:23 ` Waskiewicz Jr, Peter P
2009-01-05 5:36 ` David Miller
2009-01-06 13:02 ` Herbert Xu
2009-01-06 18:40 ` Waskiewicz Jr, Peter P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090102.001933.70654029.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=donald.c.skidmore@intel$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox