public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: frank.blaschka@de•ibm.com
To: jgarzik@pobox•com
Cc: netdev@vger•kernel.org, linux-s390@vger•kernel.org,
	Klaus-Dieter Wacker <kdwacker@de•ibm.com>
Subject: [patch 5/6] qeth: No large send using EDDP for HiperSockets.
Date: Fri, 02 Jan 2009 16:01:44 +0100	[thread overview]
Message-ID: <20090102150255.989302000@de.ibm.com> (raw)
In-Reply-To: 20090102150139.830998000@de.ibm.com

[-- Attachment #1: 609-qeth-eddp.diff --]
[-- Type: text/plain, Size: 1242 bytes --]

From: Klaus-Dieter Wacker <kdwacker@de•ibm.com>

The device driver qeth dos not support large send using EDDP for 
HiperSockets.

Signed-off-by: Klaus-Dieter Wacker <kdwacker@de•ibm.com>
Signed-off-by: Frank Blaschka <frank.blaschka@de•ibm.com>
---

 drivers/s390/net/qeth_core_main.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff -urpN linux-2.6/drivers/s390/net/qeth_core_main.c linux-2.6-patched/drivers/s390/net/qeth_core_main.c
--- linux-2.6/drivers/s390/net/qeth_core_main.c	2009-01-02 10:22:08.000000000 +0100
+++ linux-2.6-patched/drivers/s390/net/qeth_core_main.c	2009-01-02 10:22:08.000000000 +0100
@@ -287,8 +287,15 @@ int qeth_set_large_send(struct qeth_card
 	card->options.large_send = type;
 	switch (card->options.large_send) {
 	case QETH_LARGE_SEND_EDDP:
-		card->dev->features |= NETIF_F_TSO | NETIF_F_SG |
+		if (card->info.type != QETH_CARD_TYPE_IQD) {
+			card->dev->features |= NETIF_F_TSO | NETIF_F_SG |
 					NETIF_F_HW_CSUM;
+		} else {
+			card->dev->features &= ~(NETIF_F_TSO | NETIF_F_SG |
+						NETIF_F_HW_CSUM);
+			card->options.large_send = QETH_LARGE_SEND_NO;
+			rc = -EOPNOTSUPP;
+		}
 		break;
 	case QETH_LARGE_SEND_TSO:
 		if (qeth_is_supported(card, IPA_OUTBOUND_TSO)) {

-- 

  parent reply	other threads:[~2009-01-02 15:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-02 15:01 [patch 0/6] s390: qeth fixes 2.6.29 frank.blaschka
2009-01-02 15:01 ` [patch 1/6] HiperSockets mcl string conversion (pre z9 mach) frank.blaschka
2009-01-05  1:36   ` David Miller
2009-01-02 15:01 ` [patch 2/6] qeth: exploit source MAC address for inbound layer3 packets frank.blaschka
2009-01-05  1:36   ` David Miller
2009-01-02 15:01 ` [patch 3/6] qeth: avoid crash in case of layer mismatch for VSWITCH frank.blaschka
2009-01-05  1:36   ` David Miller
2009-01-02 15:01 ` [patch 4/6] qeth: do not spin for SETIP ip assist command frank.blaschka
2009-01-05  1:37   ` David Miller
2009-01-02 15:01 ` frank.blaschka [this message]
2009-01-05  1:37   ` [patch 5/6] qeth: No large send using EDDP for HiperSockets David Miller
2009-01-02 15:01 ` [patch 6/6] qeth: get rid of extra argument after printk to dev_* conversion frank.blaschka
2009-01-05  1:37   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090102150255.989302000@de.ibm.com \
    --to=frank.blaschka@de$(echo .)ibm.com \
    --cc=jgarzik@pobox$(echo .)com \
    --cc=kdwacker@de$(echo .)ibm.com \
    --cc=linux-s390@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox