From: Andi Kleen <andi@firstfloor•org>
To: Johannes Berg <johannes@sipsolutions•net>
Cc: Andi Kleen <andi@firstfloor•org>,
linux-wireless@vger•kernel.org, netdev@vger•kernel.org,
linville@tuxdriver•com, davem <davem@davemloft•net>
Subject: Re: [PATCH] Fix up truesize after pskb_expand_head() in wireless stack
Date: Mon, 5 Jan 2009 15:05:28 +0100 [thread overview]
Message-ID: <20090105140528.GR496@one.firstfloor.org> (raw)
In-Reply-To: <1231162275.3334.20.camel@johannes>
On Mon, Jan 05, 2009 at 02:31:15PM +0100, Johannes Berg wrote:
> I was under the impression that you only modified monitor mode code, but
> upon closer inspection (really, you should diff with -p, makes it a lot
> easier to review) it seems that you also touched packet defragmentation
> code. Are you running a low fragmentation threshold on your network?
I don't use any special settings, only defaults.
> Can you
> check /sys/kernel/debug/ieee80211/phy*/statistics/rx_expand_skb_head*
> please?
The kernel doesn't have 80211 debugging enabled. I can enable
it, but it will take some time until the messages reappear
(I cannot reproduce them at will, but have to wait)
>
> > > actually used those skbs then it's likely that the warning didn't result
> > > in any corruption at all.
> >
> > Nothing was corrupted ever to my knowledge, just lots of spam in my kernel logs.
>
> You wouldn't easily notice any socket memory charge corruption anyway.
There are WARN_ON(sk->sk_forward_alloc)s in the socket destroy paths
which should trigger.
-Andi
--
ak@linux•intel.com
prev parent reply other threads:[~2009-01-05 13:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-04 15:18 [PATCH] Fix up truesize after pskb_expand_head() in wireless stack Andi Kleen
[not found] ` <20090104151819.GA6590-3rXA9MLqAseW/qJFnhkgxti2O/JbrIOy@public.gmane.org>
2009-01-04 16:05 ` Johannes Berg
2009-01-04 16:28 ` Andi Kleen
[not found] ` <20090104162826.GT496-qrUzlfsMFqo/4alezvVtWx2eb7JE58TQ@public.gmane.org>
2009-01-04 16:41 ` Johannes Berg
2009-01-04 17:43 ` Andi Kleen
[not found] ` <20090104174339.GX496-qrUzlfsMFqo/4alezvVtWx2eb7JE58TQ@public.gmane.org>
2009-01-04 17:33 ` Johannes Berg
2009-01-04 18:41 ` Andi Kleen
2009-01-05 6:49 ` David Miller
2009-01-05 13:32 ` Andi Kleen
2009-01-05 8:36 ` Johannes Berg
2009-01-05 13:21 ` Andi Kleen
[not found] ` <20090105132141.GO496-qrUzlfsMFqo/4alezvVtWx2eb7JE58TQ@public.gmane.org>
2009-01-05 13:16 ` Johannes Berg
2009-01-05 13:36 ` Andi Kleen
2009-01-05 13:31 ` Johannes Berg
2009-01-05 14:05 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090105140528.GR496@one.firstfloor.org \
--to=andi@firstfloor$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=johannes@sipsolutions$(echo .)net \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox