From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public•gmane.org>
To: Alexey Klimov <klimov.linux-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org,
Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public•gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [patch review 1/3] net/usb: catc.c - place dev_err instead of err()
Date: Sun, 11 Jan 2009 13:48:37 -0800 [thread overview]
Message-ID: <200901111348.37993.david-b@pacbell.net> (raw)
In-Reply-To: <1231690591.2050.103.camel-XMdqyYT0w3Zyw3qLyVIJKA@public.gmane.org>
On Sunday 11 January 2009, Alexey Klimov wrote:
> - err("submit(rx_urb) status %d", res);
> + dev_err(&urb->dev->dev, "submit(rx_urb) status %d\n", res);
You should really find and use the device on the *interface* to which
that driver is bound, rather than the one in the URB. That's what
gets passed in to probe(); drivers normally remember that until a
remove() callback unbinds the driver from that interface.
A weak analogy is issuing a diagnostic about the PCI bus to which
the PCI device is attached, instead of the PCI device itself. In
both cases, the diagnostic would point to the wrong thing...
The other two patches got this right in at least some cases, but I
didn't look in any detail.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-01-11 21:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 16:16 [patch review 1/3] net/usb: catc.c - place dev_err instead of err() Alexey Klimov
[not found] ` <1231690591.2050.103.camel-XMdqyYT0w3Zyw3qLyVIJKA@public.gmane.org>
2009-01-11 21:48 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901111348.37993.david-b@pacbell.net \
--to=david-b-ybekhbn/0ldr7s880joybq@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=klimov.linux-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox