Subject: Re: [RFC 0/4] net namespace for PPP

From: Cyrill Gorcunov <[email-masked]>
Date: Mon, 12 Jan 2009 00:56:03 +0300

[Alexey Dobriyan - Mon, Jan 12, 2009 at 12:27:00AM +0300]
| On Fri, Jan 09, 2009 at 10:51:54PM +0300, Cyrill Gorcunov wrote:
| > here is a series of RFC in attempt to implement
| > net-namespaces for PPP protocol (including PPPoE
| > and PPPoL2TP).
| 
| You need assign netns to netdevice after alloc_netdev().
| This should fix much confusion and non-bugs mentioned in this thread.
| 
| After that struct ppp shouldn't need netns pointer as it will be netns
| of it's netdevice.

Good point, thanks!

| 
| current->nsproxy->net_ns while being correct in ioctl context
| (it's synchronous) is easy to screwup. For example, in netfilter code netns
| is taken from socket on which ioctl is done.

Didn't know that, will check.

| 
| Regardless of netns, try_module_get() calls by hand are suspicious
| and they're copied to netns init hook.
| 

Thanks a lot for comments Alexey! Module related calls are not needed
indeed.

		- Cyrill -