From: Oliver Neukum <oliver-GvhC2dPhHPQdnm+yROfE0A@public•gmane.org>
To: Alexey Klimov <klimov.linux-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
Cc: dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public•gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org,
Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public•gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [patch v2] net/usb: remove err() messages in few drivers
Date: Tue, 13 Jan 2009 09:40:26 +0100 [thread overview]
Message-ID: <200901130940.28478.oliver@neukum.org> (raw)
In-Reply-To: <1231805322.12962.4.camel-XMdqyYT0w3Zyw3qLyVIJKA@public.gmane.org>
Am Tuesday 13 January 2009 01:08:42 schrieb Alexey Klimov:
> @@ -675,7 +677,7 @@ static int kaweth_open(struct net_device *net)
>
> res = usb_autopm_get_interface(kaweth->intf);
> if (res) {
> - err("Interface cannot be resumed.");
> + dev_err(&net->dev, "Interface cannot be resumed.\n");
> return -EIO;
> }
> res = kaweth_resubmit_rx_urb(kaweth, GFP_KERNEL);
> @@ -902,7 +904,7 @@ static void kaweth_async_set_rx_mode(struct kaweth_device *kaweth)
> KAWETH_CONTROL_TIMEOUT);
>
> if(result < 0) {
> - err("Failed to set Rx mode: %d", result);
> + dev_err(&kaweth->dev->dev, "Failed to set Rx mode: %d\n", result);
> }
> else {
> dbg("Set Rx mode to %d", packet_filter_bitmap);
> @@ -1038,7 +1040,7 @@ static int kaweth_probe(
> "kaweth/new_code.bin",
> 100,
> 2)) < 0) {
> - err("Error downloading firmware (%d)", result);
> + dev_err(&intf->dev, "Error downloading firmware (%d)\n", result);
I have to veto this. You are using three different device structures
to refer to the same device. That will make it next to impossible to
find out which device originated a message.
Regards
Oliver
next prev parent reply other threads:[~2009-01-13 8:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 0:08 [patch v2] net/usb: remove err() messages in few drivers Alexey Klimov
[not found] ` <1231805322.12962.4.camel-XMdqyYT0w3Zyw3qLyVIJKA@public.gmane.org>
2009-01-13 8:40 ` Oliver Neukum [this message]
2009-01-13 8:57 ` Alexey Klimov
2009-01-13 9:25 ` Oliver Neukum
[not found] ` <200901131025.40285.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2009-01-13 9:44 ` David Brownell
2009-01-13 10:08 ` Alexey Klimov
2009-01-13 11:07 ` Oliver Neukum
[not found] ` <200901131207.03724.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2009-01-14 0:22 ` Alexey Klimov
[not found] ` <208cbae30901131622heccfee6uf312022ba1d4fb28-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-14 1:05 ` David Brownell
2009-01-14 8:09 ` Oliver Neukum
2009-01-13 9:46 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901130940.28478.oliver@neukum.org \
--to=oliver-gvhc2dphhpqdnm+yrofe0a@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public$(echo .)gmane.org \
--cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=klimov.linux-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox