From: Stephen Hemminger <shemminger@vyatta•com>
To: Masakazu Mokuno <mokuno@sm•sony.co.jp>
Cc: jgarzik@pobox•com, netdev@vger•kernel.org,
Geoff Levand <geoffrey.levand@am•sony.com>
Subject: Re: [PATCH] PS3: gelic: convert to net_device_ops
Date: Thu, 15 Jan 2009 22:07:08 -0800 [thread overview]
Message-ID: <20090115220708.6a246ff1@extreme> (raw)
In-Reply-To: <20090116134050.0B5B.40F06B3A@sm.sony.co.jp>
On Fri, 16 Jan 2009 13:57:15 +0900
Masakazu Mokuno <mokuno@sm•sony.co.jp> wrote:
> Convert the gelic driver to net_device_ops
>
> Signed-off-by: Masakazu Mokuno <mokuno@sm•sony.co.jp>
> ---
> drivers/net/ps3_gelic_net.c | 23 +++++++++++++----------
> 1 file changed, 13 insertions(+), 10 deletions(-)
>
> --- a/drivers/net/ps3_gelic_net.c
> +++ b/drivers/net/ps3_gelic_net.c
> @@ -1403,6 +1403,18 @@ void gelic_net_tx_timeout(struct net_dev
> atomic_dec(&card->tx_timeout_task_counter);
> }
>
> +static const struct net_device_ops gelic_netdevice_ops = {
> + .ndo_open = gelic_net_open,
> + .ndo_stop = gelic_net_stop,
> + .ndo_start_xmit = gelic_net_xmit,
> + .ndo_set_multicast_list = gelic_net_set_multi,
> + .ndo_change_mtu = gelic_net_change_mtu,
> + .ndo_tx_timeout = gelic_net_tx_timeout,
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> + .ndo_poll_controller = gelic_net_poll_controller,
> +#endif
>
You probably want to add:
.ndo_change_mtu = eth_change_mtu,
.ndo_set_mac_address = eth_mac_addr,
.ndo_validate_addr = eth_validate_addr,
next prev parent reply other threads:[~2009-01-16 6:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 4:57 [PATCH] PS3: gelic: convert to net_device_ops Masakazu Mokuno
2009-01-16 6:07 ` Stephen Hemminger [this message]
2009-01-16 7:09 ` Masakazu Mokuno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090115220708.6a246ff1@extreme \
--to=shemminger@vyatta$(echo .)com \
--cc=geoffrey.levand@am$(echo .)sony.com \
--cc=jgarzik@pobox$(echo .)com \
--cc=mokuno@sm$(echo .)sony.co.jp \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox