Subject: Re: [PATCH 04/21] RDS: Transport code

From: Evgeniy Polyakov <[email-masked]>
Date: Tue, 27 Jan 2009 16:18:08 +0300

On Mon, Jan 26, 2009 at 06:17:41PM -0800, Andy Grover ([email-masked]) wrote:
> +static LIST_HEAD(transports);
> +static DECLARE_RWSEM(trans_sem);
> +

RDS_ prefix?

> +int rds_trans_register(struct rds_transport *trans)
> +{
> +	BUG_ON(strlen(trans->t_name) + 1 >
> +	       sizeof(((struct rds_info_connection *)0)->transport));
> +

Wow. Why not declare 15 as some constant and put it into rds_transport
structure definition?

> +struct rds_transport *rds_trans_get_preferred(__be32 addr)
> +{
> +	struct rds_transport *trans;
> +	struct rds_transport *ret = NULL;
> +
> +        if (IN_LOOPBACK(ntohl(addr)))
> +                return &rds_loop_transport;
> +

Tabs have run away.

-- 
	Evgeniy Polyakov