Subject: [ofa-general] Re: [PATCH 04/21] RDS: Transport code

From: Evgeniy Polyakov <[email-masked]>
Date: Wed, 28 Jan 2009 00:56:58 +0300

On Tue, Jan 27, 2009 at 11:36:37AM -0800, Andrew Grover ([email-masked]) wrote:
> On Tue, Jan 27, 2009 at 5:18 AM, Evgeniy Polyakov <[email-masked]> wrote:
> > On Mon, Jan 26, 2009 at 06:17:41PM -0800, Andy Grover ([email-masked]) wrote:
> >> +static LIST_HEAD(transports);
> >> +static DECLARE_RWSEM(trans_sem);
> >> +
> >
> > RDS_ prefix?
> 
> Even needed for statics?

It confuses tags and the like otherwise, and looks more consistent with
the rest of the code. Likely it is not a must, but just better look.

-- 
	Evgeniy Polyakov