Subject: Re: [PATCH] [RESEND] iproute2 : invalid burst/cburst calculation with hrtimers

From: Stephen Hemminger <[email-masked]>
Date: Mon, 2 Feb 2009 10:07:42 -0800

On Mon, 2 Feb 2009 19:26:17 +0200
Denys Fedoryschenko <[email-masked]> wrote:

> ------------->
> iproute2 : invalid burst/cburst calculation with hrtimers
> 
> If hrtimers on, /proc/net/psched shows 4th variable 
> as 1000000000
> Because burst calculated by division rate to this variable, 
> it will be almost always zero. As result, we will get higher system 
> load on low rates, and on high rates shaper will not able to process 
> data. So it is kind of critical bugfix for systems with hrtimers.
> It is checked and proved. Core 2 Quad was not able to 
> shape 200Mbps, and gave only 180-190. It is more safe to set it 
> to 1000HZ. If user wants, he can set custom "env" HZ variable.
> 
> Signed-off-by: Denys Fedoryschenko <[email-masked]>
> ---
> 
> -------------------------------------------------------

I would rather this be converted to floating point.