From: Jarek Poplawski <jarkao2@gmail•com>
To: Denys Fedoryschenko <denys@visp•net.lb>
Cc: Stephen Hemminger <shemminger@linux-foundation•org>,
netdev@vger•kernel.org
Subject: Re: [PATCH] [RESEND] iproute2 : invalid burst/cburst calculation with hrtimers
Date: Thu, 5 Feb 2009 11:56:32 +0000 [thread overview]
Message-ID: <20090205115631.GC4305@ff.dom.local> (raw)
In-Reply-To: <200902051309.06958.denys@visp.net.lb>
On Thu, Feb 05, 2009 at 01:09:06PM +0200, Denys Fedoryschenko wrote:
> On Thursday 05 February 2009 12:08:53 Jarek Poplawski wrote:
> >
> > I lost your point... I think it's just like in your (and Martin's)
> > description to your patch. Plus you wrote it was tested OK?!
> Martin just pointed me, that burst/cburst probably is too small.
>
> I found, that it is too small because of get_hz(). Actually on highres it will
> be always 1600 (default minimal value).
And these are very good points.
> > BTW, did you try to set the same (29kb) burst/cburst manually? Did
> > you try with half of it (15kb)?
> I didn't, i guess i must calculate corresponding rates for another classes
> equally. But i try to set HZ variable to 2000 for example, i will see:
>
> class htb 1:10 parent 1:2 rate 220000Kbit ceil 220000Kbit burst 15317b cburst
> 15317b
> Sent 100864803 bytes 115615 pkt (dropped 0, overlimits 0 requeues 0)
> rate 15426Kbit 2106pps backlog 0b 0p requeues 0
> lended: 29467 borrowed: 0 giants: 0
> tokens: 533 ctokens: 533
>
> But it is difficult to know, if it works fine or not. I will try to do more
> tests for 2000 and 10000 HZ. The issue, that on that point where i had fault,
> now is less load, so i have to find another place where i can test
> differences.
I don't know where else in tc this HZ env. variable is used, so this
could change more than you need. I only wondered if setting this
manually works, so one try should be enough.
Since you tested with double size burst (~3kb?) and it didn't work,
then we know even 10000 (10x) get_hz() would be wrong. This 2x case
is only for curiosity but I think there is no reason to use more than
1000HZ for setting these defaults in tc.
Jarek P.
prev parent reply other threads:[~2009-02-05 11:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 17:26 [PATCH] [RESEND] iproute2 : invalid burst/cburst calculation with hrtimers Denys Fedoryschenko
2009-02-02 18:07 ` Stephen Hemminger
2009-02-02 18:21 ` Denys Fedoryschenko
2009-02-04 21:20 ` Jarek Poplawski
2009-02-04 21:53 ` Jarek Poplawski
2009-02-04 22:26 ` Denys Fedoryschenko
2009-02-04 22:49 ` Jarek Poplawski
2009-02-04 23:24 ` Denys Fedoryschenko
2009-02-05 7:38 ` Jarek Poplawski
2009-02-05 9:01 ` Denys Fedoryschenko
2009-02-05 10:08 ` Jarek Poplawski
2009-02-05 11:09 ` Denys Fedoryschenko
2009-02-05 11:56 ` Jarek Poplawski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205115631.GC4305@ff.dom.local \
--to=jarkao2@gmail$(echo .)com \
--cc=denys@visp$(echo .)net.lb \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox