Subject: Re: [PATCH 1/2] gigaset: return -ENOSYS for unimplemented functions

From: Arjan van de Ven <[email-masked]>
Date: Sat, 7 Mar 2009 14:26:09 -0800

On Sat,  7 Mar 2009 23:10:57 +0100 (CET)
Tilman Schmidt <[email-masked]> wrote:

> From: Paul Bolle <[email-masked]>
> 
> A number of functions in the usb_gigaset module will return -EINVAL if
> CONFIG_GIGASET_UNDOCREQ is not set. Make these return -ENOSYS as it's
> more specific and it might make it easier to see (from userspace) why
> these functions actually fail.
> 
> Impact: some error return codes changed

ENODEV is what would be more appropriate.

ENOSYS shuoldn't be returned from drivers, only from unimplemented
system calls!

-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org