From: Jarek Poplawski <jarkao2@gmail•com>
To: Herbert Xu <herbert@gondor•apana.org.au>
Cc: David Miller <davem@davemloft•net>,
emil.s.tantilov@intel•com, alexander.h.duyck@intel•com,
jesse.brandeburg@intel•com, jeffrey.t.kirsher@intel•com,
netdev@vger•kernel.org
Subject: Re: Kernel panic during stress with igb in the upstream kernel
Date: Tue, 17 Mar 2009 09:37:24 +0000 [thread overview]
Message-ID: <20090317093724.GA5743@ff.dom.local> (raw)
In-Reply-To: <20090316132240.GA18413@gondor.apana.org.au>
On 16-03-2009 14:22, Herbert Xu wrote:
...
> GRO: Move netpoll checks to correct location
...
> +static inline int netpoll_rx_on(struct sk_buff *skb)
> +{
> + struct netpoll_info *npinfo = skb->dev->npinfo;
> +
> + return npinfo && (npinfo->rx_np || npinfo->rx_flags);
> +}
> +
> static inline int netpoll_receive_skb(struct sk_buff *skb)
> {
> if (!list_empty(&skb->dev->napi_list))
> @@ -99,6 +106,10 @@ static inline int netpoll_rx(struct sk_buff *skb)
> {
> return 0;
> }
> +static inline int netpoll_rx_on(struct sk_buff *skb)
> +{
> + return 0;
> +}
> static inline int netpoll_receive_skb(struct sk_buff *skb)
> {
> return 0;
> diff --git a/net/8021q/vlan_core.c b/net/8021q/vlan_core.c
> index 2d6e405..6227248 100644
> --- a/net/8021q/vlan_core.c
> +++ b/net/8021q/vlan_core.c
> @@ -79,6 +79,9 @@ static int vlan_gro_common(struct napi_struct *napi, struct vlan_group *grp,
> {
> struct sk_buff *p;
>
> + if (netpoll_rx_on(skb))
> + return GRO_NORMAL;
> +
Probably I miss something, but you seem to assume here this skb will
be taken by netpoll later. But if it's not active (trapped) vlan
packet will be passed as "normal"?
Thanks,
Jarek P.
next prev parent reply other threads:[~2009-03-17 9:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <EA929A9653AAE14F841771FB1DE5A1365F69CA4280@rrsmsx501.amr.corp.intel.com>
2009-03-13 11:52 ` FW: Kernel panic during stress with igb in the upstream kernel Herbert Xu
2009-03-13 21:53 ` Tantilov, Emil S
2009-03-13 21:54 ` David Miller
2009-03-13 23:59 ` Herbert Xu
2009-03-16 3:13 ` David Miller
2009-03-16 3:18 ` David Miller
2009-03-16 13:22 ` Herbert Xu
2009-03-16 17:50 ` David Miller
2009-03-17 9:37 ` Jarek Poplawski [this message]
2009-03-17 10:02 ` Herbert Xu
2009-03-17 20:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090317093724.GA5743@ff.dom.local \
--to=jarkao2@gmail$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=emil.s.tantilov@intel$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox