From: Arnaldo Carvalho de Melo <acme@redhat•com>
To: Stephen Hemminger <shemminger@linux-foundation•org>
Cc: David Miller <davem@davemloft•net>, netdev@vger•kernel.org
Subject: Re: [PATCH 1/2] snap: use const for descirptor
Date: Fri, 20 Mar 2009 15:16:25 -0300 [thread overview]
Message-ID: <20090320181625.GP30407@ghostprotocols.net> (raw)
In-Reply-To: <20090320084314.5761b1d9@nehalam>
Em Fri, Mar 20, 2009 at 08:43:14AM -0700, Stephen Hemminger escreveu:
> Protocols should be able to use constant value for the descriptor.
> Minor whitespace cleanup as well
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta•com>
Looks ok, thanks
Acked-by: Arnaldo Carvalho de Melo <acme@redhat•com>
> --- a/net/802/psnap.c 2009-03-19 23:47:22.745964788 -0700
> +++ b/net/802/psnap.c 2009-03-20 08:33:46.694749299 -0700
> @@ -29,7 +29,7 @@ static struct llc_sap *snap_sap;
> /*
> * Find a snap client by matching the 5 bytes.
> */
> -static struct datalink_proto *find_snap_client(unsigned char *desc)
> +static struct datalink_proto *find_snap_client(const unsigned char *desc)
> {
> struct datalink_proto *proto = NULL, *p;
>
> @@ -122,7 +122,7 @@ module_exit(snap_exit);
> /*
> * Register SNAP clients. We don't yet use this for IP.
> */
> -struct datalink_proto *register_snap_client(unsigned char *desc,
> +struct datalink_proto *register_snap_client(const unsigned char *desc,
> int (*rcvfunc)(struct sk_buff *,
> struct net_device *,
> struct packet_type *,
> @@ -137,7 +137,7 @@ struct datalink_proto *register_snap_cli
>
> proto = kmalloc(sizeof(*proto), GFP_ATOMIC);
> if (proto) {
> - memcpy(proto->type, desc,5);
> + memcpy(proto->type, desc, 5);
> proto->rcvfunc = rcvfunc;
> proto->header_length = 5 + 3; /* snap + 802.2 */
> proto->request = snap_request;
> --- a/include/net/psnap.h 2009-03-19 23:48:33.929963947 -0700
> +++ b/include/net/psnap.h 2009-03-19 23:49:25.792963671 -0700
> @@ -1,7 +1,11 @@
> #ifndef _NET_PSNAP_H
> #define _NET_PSNAP_H
>
> -extern struct datalink_proto *register_snap_client(unsigned char *desc, int (*rcvfunc)(struct sk_buff *, struct net_device *, struct packet_type *, struct net_device *orig_dev));
> +extern struct datalink_proto *
> +register_snap_client(const unsigned char *desc,
> + int (*rcvfunc)(struct sk_buff *, struct net_device *,
> + struct packet_type *,
> + struct net_device *orig_dev));
> extern void unregister_snap_client(struct datalink_proto *proto);
>
> #endif
next prev parent reply other threads:[~2009-03-20 18:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 15:43 [PATCH 1/2] snap: use const for descirptor Stephen Hemminger
2009-03-20 15:44 ` [PATCH 2/2] ipx: use constant for strings and desciptor Stephen Hemminger
2009-03-20 15:45 ` Stephen Hemminger
2009-03-20 18:17 ` Arnaldo Carvalho de Melo
2009-03-22 2:08 ` David Miller
2009-03-20 18:16 ` Arnaldo Carvalho de Melo [this message]
2009-03-22 2:08 ` [PATCH 1/2] snap: use const for descirptor David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090320181625.GP30407@ghostprotocols.net \
--to=acme@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox