From: Grant Grundler <grundler@parisc-linux•org>
To: David Miller <davem@davemloft•net>
Cc: grundler@parisc-linux•org, kyle@mcmartin•ca,
netdev@vger•kernel.org, error27@gmail•com
Subject: Re: Null dereference in uli526x_rx_packet()
Date: Sun, 12 Apr 2009 20:45:05 -0600 [thread overview]
Message-ID: <20090413024505.GC13090@lackof.org> (raw)
In-Reply-To: <20090328.235931.45430524.davem@davemloft.net>
On Sat, Mar 28, 2009 at 11:59:31PM -0700, David Miller wrote:
> From: Grant Grundler <grundler@parisc-linux•org>
> Date: Sat, 28 Mar 2009 23:35:13 -0600
>
> > On Fri, Mar 27, 2009 at 11:23:32PM -0400, Kyle McMartin wrote:
> > > On Fri, Mar 27, 2009 at 10:47:54PM -0400, Kyle McMartin wrote:
> > > > > I don't know if the right fix is to return like this patch does or to set
> > > > > skb = rxptr->rx_skb_ptr again.
> > > > >
> > > >
> > > > Ick... that's a good catch. I'll have to think about this.
> > > >
> > >
> > > I think this is alright, it at least keeps the original intent of the
> > > code. I don't pretend to have figured it out yet though.
> > >
> > > I'll stare more at this Monday...
> > >
> > > I guess the real question is does anyone still have one of these
> > > cards. I don't think I do, just the proper tulips. :/
> >
> > Ditto. AFAIK, I only have tulips.
> >
> > Patch below looks right to me. Clobbering the skb is certainly wrong.
> >
> > Acked-by: Grant Grundler <grundler@parisc-linux•org>
>
> It looks correct to me, can we get a proper submission with
> signoffs etc.?
Dave,
Is that something I have to do or the original submitter?
Was the "Acked-by" appropriate for me to provide (as maintainer)?
I can resubmit with Signed-off-by if that's what is expected.
thanks,
grant
next prev parent reply other threads:[~2009-04-13 2:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 10:31 Null dereference in uli526x_rx_packet() Dan Carpenter
2009-03-28 2:47 ` Kyle McMartin
2009-03-28 3:23 ` Kyle McMartin
2009-03-29 5:35 ` Grant Grundler
2009-03-29 6:59 ` David Miller
2009-04-13 2:45 ` Grant Grundler [this message]
2009-04-13 2:56 ` David Miller
2010-02-07 7:15 ` Grant Grundler
2010-03-27 3:21 ` David Miller
2010-03-27 6:08 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090413024505.GC13090@lackof.org \
--to=grundler@parisc-linux$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=error27@gmail$(echo .)com \
--cc=kyle@mcmartin$(echo .)ca \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox