From: Frans Pop <elendil@planet•nl>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki•fi>
Cc: Matthias Andree <matthias.andree@gmx•de>,
Netdev <netdev@vger•kernel.org>,
David Miller <davem@davemloft•net>
Subject: Re: [PATCH v2] tcp: fix MSG_PEEK race check
Date: Mon, 11 May 2009 15:54:48 +0200 [thread overview]
Message-ID: <200905111554.50118.elendil@planet.nl> (raw)
In-Reply-To: <Pine.LNX.4.64.0905111556300.10088@wrl-59.cs.helsinki.fi>
On Monday 11 May 2009, Ilpo Järvinen wrote:
> On Mon, 11 May 2009, Frans Pop wrote:
> > On Monday 11 May 2009, Ilpo Järvinen wrote:
> > > I took my time to fix the urg_hole madness too. The patch below.
> >
> > Hmm. I wonder if it wouldn't be better to keep the two issues
> > separate. The initial patch is a clear regression fix (4 people have
> > reported it against fetchmail for Debian). The URG part is IMO a
> > separate issue which I at least have never seen in practice.
> > And my Tested-by doesn't cover the additional change either.
>
> Disagreed. It's true that your testing very likely doesn't cover such a
> corner case. The URG thing is legacy which shouldn't exist anymore but
> it might still be that some people are crazy enough to use URG not
> inline (and at the same time are doing MSG_PEEK too). However, that URG
> part is not a _separate_ issue, you might not just have a test case but
> it happens due to the very same reason and was broken by the very same
> commit.
OK. I understood that there's always been a corner case with URG that
could cause incorrect messages [1] and I thought the additional change
was to fix that, but if this is related to the same regression then of
course it's fine by me.
[1] http://linux.derkeiler.com/Mailing-Lists/Kernel/2003-09/6009.html
> This issue has nothing to do with fetchmail or so alone (regardless of
> how many bugs have been filed against it), it's generic TCP (in kernel)
> issue, whether it's triggered is just about right test pattern which
> here happens with fetchmail but it is by no means limited to it.
I never claimed that. In fact, I was the one who also saw the issue with
other applications (wget, IMAP)...
> I don't care too much if distro people have some local policies
> regarding fixes and that here shouldn't be a bother to them anyway
> since there's the more limited fix available in the archives too if
> they specifically want that.
Where did that come from? Not from anything I said...
> If you don't have URG holes, the v2 change yields to: -0 which equals
> to no-op. No testing is going to undo that :-). ...And that can be seen
> already from the patch context.
I'll still give the new patch a try on my next build :-)
The rest I happily leave up to you and David.
Thanks for clarifying.
Cheers,
FJP
next prev parent reply other threads:[~2009-05-11 13:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200902262310.12791.elendil@planet.nl>
[not found] ` <200903091749.50818.elendil@planet.nl>
[not found] ` <op.uqjiqsol1e62zd@merlin.emma.line.org>
[not found] ` <200903141900.14498.elendil@planet.nl>
2009-05-06 16:15 ` Strange Application bug, race in MSG_PEEK complaints (was: Bug#513695: fetchmail: race in MSG_PEEK) Matthias Andree
2009-05-06 23:02 ` Matthias Andree
2009-05-07 6:48 ` Ilpo Järvinen
2009-05-07 17:16 ` Frans Pop
2009-05-07 18:48 ` Ilpo Järvinen
2009-05-07 20:43 ` Frans Pop
2009-05-09 18:14 ` Frans Pop
2009-05-11 6:32 ` [PATCH v2] tcp: fix MSG_PEEK race check Ilpo Järvinen
2009-05-11 12:50 ` Frans Pop
2009-05-11 13:32 ` Ilpo Järvinen
2009-05-11 13:54 ` Frans Pop [this message]
2009-05-11 14:57 ` Ilpo Järvinen
2009-05-17 22:31 ` David Miller
2009-05-18 8:02 ` Matthias Andree
2009-05-17 22:41 ` David Miller
2009-05-18 7:24 ` Ilpo Järvinen
2009-05-18 15:34 ` Matthias Andree
2009-05-18 22:04 ` David Miller
2009-05-19 4:33 ` Ilpo Järvinen
2009-05-19 4:40 ` David Miller
2009-05-19 9:05 ` Matthias Andree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905111554.50118.elendil@planet.nl \
--to=elendil@planet$(echo .)nl \
--cc=davem@davemloft$(echo .)net \
--cc=ilpo.jarvinen@helsinki$(echo .)fi \
--cc=matthias.andree@gmx$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox