Subject: Re: [patch 2.6.31 08/10] wimax: Add netlink interface to get device state

From: Inaky Perez-Gonzalez <[email-masked]>
Date: Thu, 28 May 2009 09:16:21 -0700

On Wednesday 27 May 2009, Stephen Hemminger wrote:
> On Wed, 27 May 2009 18:05:13 -0700
>
> Inaky Perez-Gonzalez <[email-masked]> wrote:
> > From: Paulius Zaleckas <[email-masked]>
> >
> > wimax connection manager / daemon has to know what is current
> > state of the device. Previously it was only possible to get
> > notification whet state has changed.
> >
> > ...
> > ...
> > > > diff --git a/include/linux/wimax.h b/include/linux/wimax.h 
> > index c89de7f..c750f42 100644
> > --- a/include/linux/wimax.h
> > +++ b/include/linux/wimax.h
> > @@ -77,6 +77,7 @@ enum {
> >  	WIMAX_GNL_OP_MSG_TO_USER,	/* Kernel to user message */
> >  	WIMAX_GNL_OP_RFKILL,	/* Run wimax_rfkill() */
> >  	WIMAX_GNL_OP_RESET,	/* Run wimax_rfkill() */
> > +	WIMAX_GNL_OP_STATE_GET,		/* Request for current state */
> >  	WIMAX_GNL_RE_STATE_CHANGE,	/* Report: status change */
> >  };
>
> Won't adding new element in middle of list break existing ABI?

Actually that's an extremely good point that I missed completely. 
Thanks for catching it.

David, I'll submit an extra commit for correcting that point.

-- 
Inaky