From: Florian Fainelli <florian@openwrt•org>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next 2/2] cpmac: prevent fatal exception in cpmac_end_xmit
Date: Mon, 1 Jun 2009 18:36:55 +0200 [thread overview]
Message-ID: <200906011836.59413.florian@openwrt.org> (raw)
In-Reply-To: <20090601.025818.156394734.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]
Hi David,
Le Monday 01 June 2009 11:58:18 David Miller, vous avez écrit :
> From: Florian Fainelli <florian@openwrt•org>
> Date: Sun, 31 May 2009 22:59:15 +0200
>
> > From: Stefan Weil <weil@mail•berlios.de>
> >
> > We should not be stopping the subqueues in cpmac_end_xmit
> > but rather test the status of them. Replace the calls to
> > netif_subqueue_stop by __netif_subqueue_stopped. This
> > fixes an unrecoverable exception from happening when
> > running the driver.
> >
> > Signed-off-by: Stefan Weil <weil@mail•berlios.de>
> > Signed-off-by: Florian Fainelli <florian@openwrt•org>
>
> Applied, but this commit message was completely wrong and
> therefore misleading to anyone trying to track down why this
> change was made.
>
> The problem is that netif_subqueue_stopped() takes a SKB
> pointer, whereas we're passing in an integer queue index
> here.
>
> Therefore, merely providing the obvious compile warning that
> was produced by this incorrect argument type would have
> explained everything, and accurately.
You are right I should have given you the right description. Thanks for
applying it anyway.
--
Best regards, Florian Fainelli
Email : florian@openwrt•org
http://openwrt.org
-------------------------------
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2009-06-01 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-31 20:59 [PATCH net-next 2/2] cpmac: prevent fatal exception in cpmac_end_xmit Florian Fainelli
2009-06-01 9:58 ` David Miller
2009-06-01 16:36 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906011836.59413.florian@openwrt.org \
--to=florian@openwrt$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox