From: Rusty Russell <rusty@rustcorp•com.au>
To: Mark McLoughlin <markmc@redhat•com>
Cc: netdev@vger•kernel.org, virtualization@lists•linux-foundation.org
Subject: Re: [PATCH 3/4] virtio_net: don't free buffers in xmit ring
Date: Tue, 2 Jun 2009 23:37:33 +0930 [thread overview]
Message-ID: <200906022337.33799.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1243942902.9146.216.camel@blaa>
On Tue, 2 Jun 2009 09:11:42 pm Mark McLoughlin wrote:
> On Tue, 2009-06-02 at 09:13 +0100, Mark McLoughlin wrote:
> > I think skb_orphan() is enough to prevent this, is it?
>
> Oops, I meant:
>
> I don't think skb_orphan() is enough to prevent this, is it?
Yes, point taken. No, it's not. We could add nf_reset here too, which would
be perfectly sane.
I'm tempted to avoid the question marks hanging over generic skb_orphan for
now, and just do skb_orphan & nf_reset at the head of our driver.
Then look at making skb_orphan do nf_reset. It makes sense, but I'd have to
audit all the callers.
Thanks.
Rusty.
next prev parent reply other threads:[~2009-06-02 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-29 14:16 [PATCH 3/4] virtio_net: don't free buffers in xmit ring Rusty Russell
2009-06-02 8:13 ` Mark McLoughlin
2009-06-02 11:41 ` Mark McLoughlin
2009-06-02 14:07 ` Rusty Russell [this message]
2009-06-02 13:43 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906022337.33799.rusty@rustcorp.com.au \
--to=rusty@rustcorp$(echo .)com.au \
--cc=markmc@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox