From: Sergey Lapin <slapin@ossfans•org>
To: Johannes Berg <johannes@sipsolutions•net>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail•com>,
David Miller <davem@davemloft•net>,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
linux-wireless@vger•kernel.org, sfr@canb•auug.org.au
Subject: Re: [PATCH 4/6] net: add NL802154 interface for configuration of 802.15.4 devices
Date: Wed, 3 Jun 2009 16:55:07 +0400 [thread overview]
Message-ID: <20090603125507.GA22673@build.ossfans.org> (raw)
In-Reply-To: <1244027110.1693.9.camel@johannes.local>
> > +#define IEEE802154_ATTR_MAX (__IEEE802154_ATTR_MAX - 1)
> > +#define NLA_HW_ADDR NLA_U64
> > +#define NLA_GET_HW_ADDR(attr, addr) do { u64 _temp = nla_get_u64(attr); memcpy(addr, &_temp, 8); } while (0)
> > +#define NLA_PUT_HW_ADDR(msg, attr, addr) do { u64 _temp; memcpy(&_temp, addr, 8); NLA_PUT_U64(msg, attr, _temp); } while (0)
What would you propose here? adding prefix will add length to macro,
IEEE802154_NL_PUT_HW_ADDR is damn long name. Using repeated code
sequence is not better (it is error-prone and unreadable).
Any ideas?
next prev parent reply other threads:[~2009-06-03 12:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 9:33 [MERGE REQUEST] IEEE 802.15.4 stack: generic parts Dmitry Eremin-Solenikov
2009-06-03 9:33 ` [PATCH 1/6] crc-itu-t: add bit-reversed calculation Dmitry Eremin-Solenikov
2009-06-03 9:33 ` [PATCH 2/6] Add constants for the ieee 802.15.4/ZigBee stack Dmitry Eremin-Solenikov
2009-06-03 9:33 ` [PATCH 3/6] net: add IEEE 802.15.4 socket family implementation Dmitry Eremin-Solenikov
[not found] ` <1244021629-18409-4-git-send-email-dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-06-03 9:33 ` [PATCH 4/6] net: add NL802154 interface for configuration of 802.15.4 devices Dmitry Eremin-Solenikov
[not found] ` <1244021629-18409-5-git-send-email-dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-06-03 9:33 ` [PATCH 5/6] ieee802154: add documentation about our stack Dmitry Eremin-Solenikov
[not found] ` <1244021629-18409-6-git-send-email-dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-06-03 9:33 ` [PATCH 6/6] ieee802154: add simple HardMAC driver sample Dmitry Eremin-Solenikov
2009-06-03 9:39 ` [PATCH 4/6] net: add NL802154 interface for configuration of 802.15.4 devices Johannes Berg
[not found] ` <1244021964.10665.5.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-06-03 10:09 ` David Miller
2009-06-03 10:52 ` Dmitry Eremin-Solenikov
2009-06-03 11:05 ` Johannes Berg
[not found] ` <1244027110.1693.9.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-06-03 12:27 ` Dmitry Eremin-Solenikov
2009-06-04 14:12 ` Johannes Berg
[not found] ` <1244124749.22576.71.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-06-04 14:51 ` Dmitry Eremin-Solenikov
[not found] ` <bc64b4640906040751i3c64c317i4eedb7d53307092a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-06-04 15:12 ` Patrick McHardy
[not found] ` <4A27E448.3040305-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2009-06-04 15:14 ` Dmitry Eremin-Solenikov
[not found] ` <bc64b4640906040814m1756ea13s19e20592ecf90e9b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-06-04 15:15 ` Patrick McHardy
2009-06-03 12:55 ` Sergey Lapin [this message]
2009-06-03 14:21 ` Patrick McHardy
2009-06-03 23:12 ` Dmitry Eremin-Solenikov
2009-06-03 10:08 ` [PATCH 2/6] Add constants for the ieee 802.15.4/ZigBee stack David Miller
[not found] ` <20090603.030826.03512651.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2009-06-03 10:51 ` Dmitry Eremin-Solenikov
2009-06-03 21:19 ` David Miller
[not found] ` <20090603.141919.261921857.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2009-06-03 23:15 ` Dmitry Eremin-Solenikov
2009-06-04 0:49 ` David Miller
2009-06-03 12:43 ` [PATCH 1/6] crc-itu-t: add bit-reversed calculation Ben Hutchings
2009-06-03 12:48 ` Dmitry Eremin-Solenikov
2009-06-04 0:49 ` Dmitry Eremin-Solenikov
2009-06-21 8:29 ` Dmitry Eremin-Solenikov
[not found] ` <20090621082921.GA12749-nIupHZaCssqR2kOLt6zJ8ErlnG4Plg33XqFh9Ls21Oc@public.gmane.org>
2009-06-21 10:18 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603125507.GA22673@build.ossfans.org \
--to=slapin@ossfans$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dbaryshkov@gmail$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox