Subject: Re: [PATCH 2/2] forcedeth: Addition of new device id

From: Andrew Morton <[email-masked]>
Date: Wed, 3 Jun 2009 14:52:38 -0700

On Wed, 03 Jun 2009 14:26:47 -0700 (PDT)
David Miller <[email-masked]> wrote:

> From: Andrew Morton <[email-masked]>
> Date: Wed, 3 Jun 2009 13:25:09 -0700
> 
> > On Tue, 02 Jun 2009 15:18:50 -0400
> > Ayaz Abdulla <[email-masked]> wrote:
> > 
> >> This patch adds support for new ethernet device in the MCP89 chipset.
> >> 
> >> Signed-off-by: Ayaz Abdulla <[email-masked]>
> >> 
> > 
> > It's best to combine these two patches into one, IMO.
> 
> Andrew, we do not add new entries to pci_ids.h any more.

Lots of people are still changing it.  I believe that the approach
we've been taking is: if the driver presently uses pci_ids.h and you're
adding a new ID then go for it.  But new drivers should use a private
site for the IDs.  And patches which switch old drivers from pci_ids
over to a private site are approved of.

> Just use the constant directly when using it in the driver
> ID table.

Well OK, but that means that forcedeth has most of its PCI IDs
enumerated in pci_ids.h, but others hardwired in forcedeth.c.

IOW, Ayaz owes us a "[patch] forcedeth: remove PCI IDs from pci_ids.h" ;)