public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Mark Smith <lk-netdev@lk-netdev•nosense.org>
To: Florian Westphal <fw@strlen•de>
Cc: netdev@vger•kernel.org, davem@davemloft•net
Subject: Re: [PATCH] econet: have failed ec_queue_packet() call return NET_RX_BAD
Date: Sat, 20 Jun 2009 20:50:26 +0930	[thread overview]
Message-ID: <20090620205026.05219c33.lk-netdev@lk-netdev.nosense.org> (raw)
In-Reply-To: <20090620105325.GC31266@Chamillionaire.breakpoint.cc>

Hi Florian,

On Sat, 20 Jun 2009 12:53:25 +0200
Florian Westphal <fw@strlen•de> wrote:

> Mark Smith <lk-netdev@lk-netdev•nosense.org> wrote:
> > econet_rcv() calls ec_queue_packet(). The return from ec_queue_packet()
> > is the direct result of a call to sock_queue_rcv_skb(). Error returns
> > from ec_queue_packet() and therefore sock_queue_rcv_skb() are due to
> > kernel errors, so have econet_rcv() return NET_RX_BAD in this case.
> 
> What about doing this instead?
> 

I think there is value in distinguishing between network/protocol
errors and kernel errors. It helps determine where the fault might lie
- in the network somewhere, or isolated to the receiving host. In
larger organisations there is typically a networks support team and a
hosts/sys admin team. Hints such as this that help determine who's
problem the fault is to deal with can be a big time saver (being a
networking person on one of these sorts of teams, I'm scrathing an
itch :-) )

If these econet patches are accepted, I'll send through similar patches
for the other protocols in the kernel where necessary.

Thanks,
Mark.

next prev parent reply	other threads:[~2009-06-20 11:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-20 10:34 [PATCH] econet: have failed ec_queue_packet() call return NET_RX_BAD Mark Smith
2009-06-20 10:53 ` Florian Westphal
2009-06-20 11:20   ` Mark Smith [this message]
2009-06-22  5:50     ` David Miller
2009-06-22  6:50       ` Mark Smith
2009-07-06  2:47   ` David Miller
2009-07-06 10:32     ` Mark Smith
2009-07-06 18:48       ` David Miller
2009-07-06 21:07         ` Mark Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090620205026.05219c33.lk-netdev@lk-netdev.nosense.org \
    --to=lk-netdev@lk-netdev$(echo .)nosense.org \
    --cc=davem@davemloft$(echo .)net \
    --cc=fw@strlen$(echo .)de \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox