Subject: Re: [RFC] [PATCH 2/7] crypto: authenc - convert to ahash

From: David Miller <[email-masked]>
Date: Fri, 17 Jul 2009 10:03:34 -0700 (PDT)

From: Steffen Klassert <[email-masked]>
Date: Thu, 16 Jul 2009 13:17:47 +0200

> +	/* 
> +	 * head must be a scatterlist with two entries.
> +	 * We remove a potentially set termination bit
> +	 * on the first enty.
> +	 */
> +	head->page_link &= ~0x02;
> +
>  	if (chain) {
>  		head->length += sg->length;

Isn't there some interface to do this, rather than revealing the
implementation details of how the scatter list marking works?

If not, such an interface should be created and used here.  Otherwise
any change in that implementation will break this code.