From: Simon Horman <horms@verge•net.au>
To: David Miller <davem@davemloft•net>
Cc: eric.dumazet@gmail•com, lvs-devel@vger•kernel.org,
netdev@vger•kernel.org, julius.volz@gmail•com,
robert.gallagher@heanet•ie
Subject: Re: [PATCH] IPVS: Add handling of incoming ICMPV6_PKT_TOOBIG messages
Date: Mon, 27 Jul 2009 12:37:55 +1000 [thread overview]
Message-ID: <20090727023754.GC723@verge.net.au> (raw)
In-Reply-To: <20090726.191905.158195470.davem@davemloft.net>
On Sun, Jul 26, 2009 at 07:19:05PM -0700, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail•com>
> Date: Fri, 24 Jul 2009 06:25:25 +0200
>
> > I see no reference to ICMPV6_PKT_TOOBIG in this patch, so ChangeLog
> > might be misleading or uncomplete, since other ICMPV6 message types
> > (ICMPV6_DEST_UNREACH/ICMPV6_TIME_EXCEED) will also be forwarded/handled
> > ?
>
> Agreed, this commit message could use a tidy. What the patch actually is
> doing is adding the handling of ipv6 icmp messages at all.
>
> Simon could you clarify the commit message a bit and resubmit?
Will do.
next prev parent reply other threads:[~2009-07-27 2:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 13:22 [PATCH] IPVS: Add handling of incoming ICMPV6_PKT_TOOBIG messages Julius Volz
2009-06-28 15:43 ` Simon Horman
2009-07-02 14:43 ` Julius Volz
2009-07-10 9:56 ` Simon Horman
2009-07-24 2:47 ` Simon Horman
2009-07-24 4:25 ` Eric Dumazet
2009-07-27 2:19 ` David Miller
2009-07-27 2:37 ` Simon Horman [this message]
2009-07-27 10:19 ` Julius Volz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090727023754.GC723@verge.net.au \
--to=horms@verge$(echo .)net.au \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=julius.volz@gmail$(echo .)com \
--cc=lvs-devel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robert.gallagher@heanet$(echo .)ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox