Subject: Re: [PATCH 7/7] venet: add scatter-gather/GSO support

From: Stephen Hemminger <[email-masked]>
Date: Mon, 3 Aug 2009 11:33:55 -0700

On Mon, 03 Aug 2009 13:18:07 -0400
Gregory Haskins <[email-masked]> wrote:

> +	struct {
> +		int                sg:1;
> +		int                tso:1;
> +		int                ufo:1;
> +		int                tso6:1;
> +		int                ecn:1;
> +	} flags;

Why do you have to shadow flags that are already available in net_device?
It is bad design to replicate state in a device driver. The problem
with replicated state is that it has to be updated in both places.

--