Subject: Re: [PATCH] sky2: Add a mutex around ethtools operations

From: Stephen Hemminger <[email-masked]>
Date: Wed, 5 Aug 2009 17:42:41 -0700

On Thu, 06 Aug 2009 07:46:02 +0900
Mike McCormack <[email-masked]> wrote:

> As multiple sky2 devices share some of the same hardware, and ethtool
> operations are per device, access to transmit timers, eeprom access,
>  coalesce, etc. should be serialized.
> 
> Only tested on a single port card, as my sky2 doesn't have dual ports.
> 
> Signed-off-by: Mike McCormack <[email-masked]>

NAK.
The ethtool operations are already serialized by rtnl mutex at
higher level.  See net/core/dev.c 
--