Subject: Re: [PATCH] sky2: Serialize access to PCI config space

From: Stephen Hemminger <[email-masked]>
Date: Thu, 6 Aug 2009 08:34:36 -0700

On Thu, 06 Aug 2009 20:10:27 +0900
Mike McCormack <[email-masked]> wrote:

> PCI config space may be shared across two device instances,
>  or accessed from an interrupt
>  , so serialize access so
>  read-update-write operations do not interfere with each other.
> 
> Only tested on a single port card, as my sky2 doesn't have dual ports.
> 
> Signed-off-by: Mike McCormack <[email-masked]>

No, more locks is not better design.  Better to just use existing
RTNL mutex consistently.