Subject: Re: [PATCH] sky2: Create buffer alloc and free helpers

From: Stephen Hemminger <[email-masked]>
Date: Mon, 10 Aug 2009 08:29:43 -0700

On Sun, 09 Aug 2009 20:40:16 +0900
Mike McCormack <[email-masked]> wrote:

> Refactor similar two sections of code that free buffers into one.
> As a side effect, only call tx_init() in sky2_up() if all buffer 
>  allocations succeed.
> 
> Signed-off-by: Mike McCormack <[email-masked]>

> +	if (0 > sky2_alloc_buffers(sky2))
>  		goto err_out;

Don't change code style. Especially in mid driver.

Just return 0 for success and errno or -1.