Subject: Re: [PATCH] sky2: Don't try to turn led off in sky2_down()

From: Stephen Hemminger <[email-masked]>
Date: Sat, 29 Aug 2009 10:57:27 -0700

On Sat, 29 Aug 2009 22:10:33 +0900
Mike McCormack <[email-masked]> wrote:

> There are a few problems with the following line of code in sky2_down()
> 
>      sky2_write16(hw, B0_Y2LED, LED_STAT_OFF);
> 
>  * It doesn't specify which port's LED to turn off.
>  * We don't turn send LED_STAT_ON on in sky2_up()
>  * B0_LED is 0x0006 in the vendor driver, but 0x0005 in sky2.
>    B0_LED is right next to B0_POWER_CTRL, so this is possibly
>    accounts for the device being accidently powered down as
>    reported by Rene Mayrhofer.

I would rather just change the definition of B0_LED to the correct value.