Subject: Re: [PATCH] sky2: fix management of driver LED

From: Stephen Hemminger <[email-masked]>
Date: Tue, 1 Sep 2009 21:33:25 -0700

On Tue, 01 Sep 2009 17:44:37 -0700 (PDT)
David Miller <[email-masked]> wrote:

> From: Stephen Hemminger <[email-masked]>
> Date: Mon, 31 Aug 2009 10:31:41 -0700
> 
> > Observed by Mike McCormack.
> > 
> > The LED bit here is just a software controlled value used to
> > turn on one of the LED's on some boards. The register value was wrong,
> > which could have been causing some power control issues.
> > Get rid of problematic define use the correct mask.
> > 
> > Signed-off-by: Stephen Hemminger <[email-masked]>
> 
> Applied.

If these power management fixes do fix all the reported problems,
then I will consider back porting (probably to 2.6.31.1).

--