From: Tilman Schmidt <tilman-ZTO5kqT2PaM@public•gmane.org>
To: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org,
Karsten Keil <keil-shG/GajIFYqbacvFa/9K2g@public•gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
i4ldeveloper-JX7+OpRa80SjiSfgN6Y1Ib39b6g2fGNp@public•gmane.org
Cc: Carsten Paeth <calle-xPGHEYvgodo@public•gmane.org>
Subject: [PATCH 2/4] isdn: accept CAPI Informational Info values as success
Date: Sun, 6 Sep 2009 20:58:52 +0200 (CEST) [thread overview]
Message-ID: <20090906-patch-capi-2.tilman@imap.cc> (raw)
In-Reply-To: <20090906-patch-capi-0.tilman-ZTO5kqT2PaM@public.gmane.org>
Info values in the 0x00xx range are defined in the CAPI standard
as "Informational, message processed successfully". Therefore a
CONNECT_B3_CONF message with an Info value in that range should
open an NCCI just as with Info==0.
Signed-off-by: Tilman Schmidt <tilman-ZTO5kqT2PaM@public•gmane.org>
Acked-by: Karsten Keil <keil-shG/GajIFYqbacvFa/9K2g@public•gmane.org>
---
drivers/isdn/capi/capi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/capi/capi.c b/drivers/isdn/capi/capi.c
index 2d83524..65bf91e 100644
--- a/drivers/isdn/capi/capi.c
+++ b/drivers/isdn/capi/capi.c
@@ -603,7 +603,7 @@ static void capi_recv_message(struct capi20_appl *ap, struct sk_buff *skb)
if (CAPIMSG_CMD(skb->data) == CAPI_CONNECT_B3_CONF) {
u16 info = CAPIMSG_U16(skb->data, 12); // Info field
- if (info == 0) {
+ if ((info & 0xff00) == 0) {
mutex_lock(&cdev->ncci_list_mtx);
capincci_alloc(cdev, CAPIMSG_NCCI(skb->data));
mutex_unlock(&cdev->ncci_list_mtx);
--
1.6.2.1.214.ge986c
next prev parent reply other threads:[~2009-09-06 18:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-06 18:58 [PATCH 0/4] ISDN patches for 2.6.32 Tilman Schmidt
2009-09-06 18:58 ` [PATCH 4/4] isdn: make capidrv module parameter "debugmode" writeable Tilman Schmidt
[not found] ` <20090906-patch-capi-0.tilman-ZTO5kqT2PaM@public.gmane.org>
2009-09-06 18:58 ` [PATCH 1/4] Documentation: expand isdn/INTERFACE.CAPI document Tilman Schmidt
2009-09-06 18:58 ` Tilman Schmidt [this message]
2009-09-06 18:58 ` [PATCH 3/4] isdn: avoid races in capidrv Tilman Schmidt
-- strict thread matches above, loose matches on Subject: below --
2009-09-18 23:57 [PATCH 0/4] ISDN patches for 2.6.32 (v2) Tilman Schmidt
2009-09-18 23:57 ` [PATCH 2/4] isdn: accept CAPI Informational Info values as success Tilman Schmidt
2009-10-06 22:17 [PATCH 0/4] ISDN patches for 2.6.32 (v3) Tilman Schmidt
2009-10-06 22:18 ` [PATCH 2/4] isdn: accept CAPI Informational Info values as success Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090906-patch-capi-2.tilman@imap.cc \
--to=tilman-zto5kqt2pam@public$(echo .)gmane.org \
--cc=calle-xPGHEYvgodo@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=i4ldeveloper-JX7+OpRa80SjiSfgN6Y1Ib39b6g2fGNp@public$(echo .)gmane.org \
--cc=keil-shG/GajIFYqbacvFa/9K2g@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox