From: Sascha Hauer <s.hauer@pengutronix•de>
To: Kurt Van Dijck <kurt.van.dijck@eia•be>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH 1/2] Add an alternative cs89x0 driver
Date: Mon, 7 Sep 2009 15:21:31 +0200 [thread overview]
Message-ID: <20090907132131.GA25789@pengutronix.de> (raw)
In-Reply-To: <20090907123554.GA2928@e-circ.dyndns.org>
On Mon, Sep 07, 2009 at 02:35:54PM +0200, Kurt Van Dijck wrote:
> On Mon, Sep 07, 2009 at 12:24:34PM +0200, Sascha Hauer wrote:
> > Date: Mon, 7 Sep 2009 12:24:34 +0200
> > Subject: Re: [PATCH 1/2] Add an alternative cs89x0 driver
> > From: Sascha Hauer <s.hauer@pengutronix•de>
> > To: Kurt Van Dijck <kurt.van.dijck@eia•be>
> > Cc: netdev@vger•kernel.org
> > List-ID: <netdev.vger.kernel.org>
> >
> > Hi Kurt,
> >
> > On Wed, Aug 26, 2009 at 12:46:34PM +0200, Kurt Van Dijck wrote:
> > > Hi Sacha,
> > >
> > > I'm using a 2.6.25.
> > > Converting to your platform_device based driver,
> > > I needed to configure the irq (see patch, irq flags).
> > > Looking in the old cs89x0.c, it's done in the driver. Should I have
> > > configured the irq level elsewhere? Or is this patch valid to do?
> >
> > This is the way to go. I don't know if the cs89x0 has configurable
> > interrupt levels though.
> I haven't read any spec about cs89x0, but by looking in the existing
> code:
> 1) IRQF_TRIGGER_HIGH seems like the default
> 2) the old driver didn't do any irq config in the chip either.
> May I assume you were lucky testing the driver on a platform that had
> IRQF_TRIGGER_HIGH per default?
> I have it running (with patch) on a iMX31 (arm)
I tested it with an i.MX1. Looking at the code it seems that
__irq_set_trigger is only called if one of the trigger mask bits is set.
So the interrupt control registers are never touched when 0 is passed as
irq flags. The reset default for i.MX is rising edge.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2009-09-07 13:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 7:59 [PATCH] Add new cs89x0 driver Sascha Hauer
2009-04-22 7:59 ` [PATCH 1/2] Add an alternative " Sascha Hauer
2009-04-22 7:59 ` [PATCH 2/2] mx1ads: Add cs89x0 network support Sascha Hauer
2009-04-22 9:28 ` [PATCH 1/2] Add an alternative cs89x0 driver Ivo Clarysse
2009-04-22 12:18 ` Sascha Hauer
2009-04-22 9:42 ` Gilles Chanteperdrix
2009-04-22 12:20 ` Sascha Hauer
2009-04-22 12:25 ` Gilles Chanteperdrix
2009-04-22 13:05 ` Sascha Hauer
2009-08-26 10:46 ` Kurt Van Dijck
2009-09-07 10:24 ` Sascha Hauer
2009-09-07 12:35 ` Kurt Van Dijck
2009-09-07 13:21 ` Sascha Hauer [this message]
2009-10-16 9:37 ` Kurt Van Dijck
2009-04-22 22:53 ` [PATCH] Add new " Lennert Buytenhek
2009-04-23 7:03 ` Sascha Hauer
2009-10-20 9:55 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090907132131.GA25789@pengutronix.de \
--to=s.hauer@pengutronix$(echo .)de \
--cc=kurt.van.dijck@eia$(echo .)be \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox