Subject: Re: [PATCH] atm: dereference of he_dev->rbps_virt in he_init_group()

From: David Miller <[email-masked]>
Date: Fri, 11 Sep 2009 12:37:25 -0700 (PDT)

From: Roel Kluin <[email-masked]>
Date: Sat, 05 Sep 2009 14:35:18 +0200

> he_dev->rbps_virt or he_dev->rbpl_virt allocation may fail, so check
> them. Make sure that he_init_group() cleans up after errors.
> 
> Signed-off-by: Roel Kluin <[email-masked]>
> ---
>> These new return statements will both leak resources allocated
>> earlier.
>> 
>> All the caller is going to do is return -ENOMEM as well and
>> it does not cleanup actions at all.
>> 
>> Please fix this up.
> 
> I am new to this api, so please review.

Looks ok, applied, thanks.