public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Arnaldo Carvalho de Melo <acme@redhat•com>
To: David Miller <davem@davemloft•net>
Cc: "Caitlin Bestler" <caitlin.bestler@gmail•com>,
	"Chris Van Hoof" <vanhoof@redhat•com>,
	"Clark Williams" <williams@redhat•com>,
	"Neil Horman" <nhorman@tuxdriver•com>,
	"Nir Tzachar" <nir.tzachar@gmail•com>,
	"Nivedita Singhvi" <niv@us•ibm.com>,
	"Paul Moore" <paul.moore@hp•com>,
	"Rémi Denis-Courmont" <remi.denis-courmont@nokia•com>,
	"Steven Whitehouse" <steve@chygwyn•com>,
	"Linux Networking Development Mailing List"
	<netdev@vger•kernel.org>
Subject: [RFCv4 PATCH 0/2] net: Introduce recvmmsg socket syscall
Date: Wed, 16 Sep 2009 14:07:33 -0300	[thread overview]
Message-ID: <20090916170733.GB7699@ghostprotocols.net> (raw)

Hi,

	Nir, can you please test with this patchset and check if latency
numbers improved? They should, I think :-)

	New perf callgraphs here:

http://oops.ghostprotocols.net:81/acme/perf.recvmsg.step2.cg.data.txt.bz2

versus

http://oops.ghostprotocols.net:81/acme/perf.recvmmsg.step2.cg.data.txt.bz2

	Look at what appears now on the radar, its not locking :-)
	
	Or course, I need to do more tests, but it looks promising, please give
it a go and report back here if you can!

- Arnaldo

# Samples: 761074
#
# Overhead   Command             Shared Object  Symbol
# ........  ........  ........................  ......
#
     6.54%  recvmmsg  [kernel]                  [k] skb_set_owner_r
                |
                |--99.43%-- sock_queue_rcv_skb
                |          __udp_queue_rcv_skb
                |          sk_backlog_rcv
                |          release_sock
                |          __sys_recvmmsg
                |          sys_recvmmsg
                |          system_call_fastpath
                |          syscall
                |          |
                |           --12.76%-- main
                |                     __libc_start_main
                |
                 --0.57%-- __udp_queue_rcv_skb
                           sk_backlog_rcv
                           release_sock
                           __sys_recvmmsg
                           sys_recvmmsg
                           system_call_fastpath
                           syscall
                           |
                            --10.84%-- main
                                      __libc_start_main

     5.88%  recvmmsg  [kernel]                  [k] _spin_lock_irqsave
                |
                |--47.58%-- skb_queue_tail
                |          sock_queue_rcv_skb
                |          __udp_queue_rcv_skb
                |          sk_backlog_rcv
                |          release_sock
                |          __sys_recvmmsg
                |          sys_recvmmsg
                |          system_call_fastpath
                |          syscall
                |          |
                |           --12.56%-- main
                |                     __libc_start_main
                |
                |--41.85%-- __skb_recv_datagram
                |          __udp_recvmsg
                |          udp_unlocked_recvmsg
                |          sock_common_unlocked_recvmsg
                |          __sock_unlocked_recvmsg_nosec
                |          |
                |          |--98.41%-- sock_unlocked_recvmsg_nosec
                |          |          __sys_recvmsg
                |          |          __sys_recvmmsg
                |          |          sys_recvmmsg
                |          |          system_call_fastpath
                |          |          syscall
                |          |          |
                |          |           --12.82%-- main
                |          |                     __libc_start_main
                |          |
                |           --1.59%-- sock_unlocked_recvmsg
                |                     __sys_recvmsg
                |                     __sys_recvmmsg
                |                     sys_recvmmsg


- Arnaldo

                 reply	other threads:[~2009-09-16 17:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090916170733.GB7699@ghostprotocols.net \
    --to=acme@redhat$(echo .)com \
    --cc=caitlin.bestler@gmail$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=nhorman@tuxdriver$(echo .)com \
    --cc=nir.tzachar@gmail$(echo .)com \
    --cc=niv@us$(echo .)ibm.com \
    --cc=paul.moore@hp$(echo .)com \
    --cc=remi.denis-courmont@nokia$(echo .)com \
    --cc=steve@chygwyn$(echo .)com \
    --cc=vanhoof@redhat$(echo .)com \
    --cc=williams@redhat$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox